Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ui5 use: Allow using versions according to Semantic Versioning #341

Merged
merged 1 commit into from
May 29, 2020

Conversation

matz3
Copy link
Member

@matz3 matz3 commented May 28, 2020

Validation of the version is now only done within ui5-project

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

Validation of the version is now only done within ui5-project
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 93.037% when pulling f450d66 on fix-use-command-prerelease-versions into 46d590e on master.

Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this way around it's way easier

@matz3
Copy link
Member Author

matz3 commented May 29, 2020

Although this should be independent, I'll wait to merge this until we have a release of SAP/ui5-project#326 so that both are released together.

@matz3 matz3 merged commit d7a9363 into master May 29, 2020
@RandomByte RandomByte deleted the fix-use-command-prerelease-versions branch August 3, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants